Add CSEPass to default edge lowering passes (#19861)#19861
Open
pssrawat wants to merge 1 commit into
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19861
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (2 Unrelated Failures)As of commit 6cb3f9c with merge base 42581f1 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@pssrawat has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106585672. |
Summary: Move CSEPass into the default edge lowering pipeline so callers do not need to opt in individually. Changes: 1. executorch/exir/program/_program.py: prepend CSEPass() to the pass list built by edge_to_executorch_passes(), before *config.passes. This re-runs CSE at the edge -> executorch boundary (matching where export_llm_backbone.py runs it manually today) so that any new redundancies introduced by user-supplied or downstream passes are also deduped. Differential Revision: D106585672
meta-codesync
Bot
changed the title
pssrawat
force-pushed
the
export-D106585672
branch
from
034c202 to
6cb3f9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Move CSEPass into the default edge
lowering pipeline so callers do not need to opt in individually.
Changes:
list built by edge_to_executorch_passes(), before *config.passes.
This re-runs CSE at the edge -> executorch boundary (matching where
export_llm_backbone.py runs it manually today) so that any new
redundancies introduced by user-supplied or downstream passes are
also deduped.
Differential Revision: D106585672